Skip to content

Commit

Permalink
Merge fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
EliteAsian123 committed May 15, 2023
1 parent 532a398 commit 9c49bd1
Showing 1 changed file with 6 additions and 15 deletions.
21 changes: 6 additions & 15 deletions Assets/Script/PlayMode/AbstractTrack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public EventInfo FillSection {
private double soloPtsEarned;

private bool FullCombo = true;

// Used for performance text purposes
private bool hotStartChecked = false;
private bool fullComboChecked = false;
Expand All @@ -77,6 +78,7 @@ public EventInfo FillSection {

private int _combo = 0;
private int _recentCombo = 0; // For tracking note streak of size interval / 2

protected int Combo {
get => _combo;
set {
Expand Down Expand Up @@ -173,20 +175,6 @@ private void Start() {
commonTrack.kickFlash.SetActive(false);

scoreKeeper = new();

// Set up performance text for BASS GROOVE and other similar messages
commonTrack.performanceText.color = Color.white;
commonTrack.perfTextSizer = new PerformanceTextSizer(
commonTrack.perfTextFontSize,
commonTrack.perfTextAnimLen);

// Set the end time for STRONG FINISH and FULL COMBO performance text checking
endTime = (Chart[Chart.Count - 1].time + Constants.HIT_MARGIN + commonTrack.bufferPeriod);
offsetEndTime = endTime + commonTrack.perfTextAnimLen;

// Initlaize interval sizes
intervalSize = commonTrack.noteStreakInterval;
halfIntervalSize = intervalSize / 2;

// Set the end time for STRONG FINISH and FULL COMBO performance text checking
endTime = Chart[^1].time + Constants.HIT_MARGIN + commonTrack.bufferPeriod;
Expand Down Expand Up @@ -244,7 +232,7 @@ private void Update() {
if (hitChartIndex > lastHit) {
lastHit = hitChartIndex;
}

// NOTE: UpdateInfo() originally was before UpdateStarpower().
// Moved it to the end to make performance text things work.
// I REALLY hope that doesn't break something. - grishhung
Expand Down Expand Up @@ -515,6 +503,7 @@ private void UpdateInfo() {
}

commonTrack.comboMeterRenderer.material.SetFloat("SpriteNum", index);

// HOT START notifs
if (commonTrack.hotStartNotifsEnabled) {
if (!hotStartChecked) {
Expand All @@ -540,6 +529,7 @@ private void UpdateInfo() {
commonTrack.TrackView.ShowPerformanceText($"{currentNoteStreakInterval * intervalSize}-NOTE STREAK");
}
}

// BASS GROOVE notifs
// NOTE: This will always trump "X-NOTE STREAK" (in particular, "50-NOTE STREAK")
if (commonTrack.bassGrooveNotifsEnabled) {
Expand All @@ -553,6 +543,7 @@ private void UpdateInfo() {
}
}
}

// OVERDRIVE READY notifs
if (commonTrack.overdriveReadyNotifsEnabled) {
if (recentStarpowerCharge < 0.5f && starpowerCharge >= 0.5f && !IsStarPowerActive) {
Expand Down

0 comments on commit 9c49bd1

Please sign in to comment.