Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/FE-047: BottomButton 컴포넌트 #84

Merged
merged 8 commits into from
Jul 9, 2023
Merged

Feature/FE-047: BottomButton 컴포넌트 #84

merged 8 commits into from
Jul 9, 2023

Conversation

jieunpark247
Copy link
Contributor

@jieunpark247 jieunpark247 commented Jul 4, 2023 •
edited
Loading

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 관련된 이슈와 연결 시켰나요?
  • Target Branch를 올바르게 설정했나요?
  • Label을 알맞게 설정했나요?

작업 내역

  • �BottomButton 컴포넌트 추가
  • Button Mobile 버전에서 부모 컴포넌트에 따라 크기 변동
  • Button size에서 부모 크기에 따라서 변동 가능하게 'custom' 타입 추가

비고

  • 모바일 전용 고정 버튼입니다.

    • 자동으로 모바일 사이즈가 되면 화면에 노출 되는 것으로 수정 (07.06)
    • errorMsg 에 메세지 내용을 추가하면 Msg Error 필드 추가

  • Button size 가 고정 되어있다보니 새로운 버튼 사이즈가 나오면 사용하기 어려운 것 같아 width: 100% 인 버튼을 추가해놓았습니다. className을 통해 padding, fontSize, radius 등을 부모를 통해 전달하면 되며, 부모요소에 따라 크기가 조절 될 수 있습니다.

@jieunpark247 jieunpark247 changed the title Feature/FE-47: BottomButton 컴포넌트 Feature/FE-047: BottomButton 컴포넌트 Jul 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

naro-Kim
naro-Kim approved these changes Jul 9, 2023
View reviewed changes
Copy link
Contributor

@naro-Kim naro-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커스텀 variants까지 확인했습니다. 고생하셨습니다! ✅

sxungchxn
sxungchxn approved these changes Jul 9, 2023
View reviewed changes
Copy link
Member

@sxungchxn sxungchxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BottomButton 작업 수고하셨습니다

@naro-Kim naro-Kim merged commit 5466006 into dev Jul 9, 2023
3 checks passed
@naro-Kim naro-Kim deleted the feature/FE-047 branch July 9, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxungchxn sxungchxn sxungchxn approved these changes

@naro-Kim naro-Kim naro-Kim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jieunpark247 @sxungchxn @naro-Kim