Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/FE-053 : Input 컴포넌트 fixed Height helper text 대응 #73

Merged
merged 3 commits into from
Jul 4, 2023
Merged

feature/FE-053 : Input 컴포넌트 fixed Height helper text 대응 #73

merged 3 commits into from
Jul 4, 2023

Conversation

naro-Kim
Copy link
Contributor

@naro-Kim naro-Kim commented Jul 3, 2023

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 관련된 이슈와 연결 시켰나요?
  • Target Branch를 올바르게 설정했나요?
  • Label을 알맞게 설정했나요?

작업 내역

  • 디자인 요구사항에 따라 Input컴포넌트에 fix props를 전달하면 error message가 생겨도 위치가 변하지 않도록 했습니다.
  • fix의 기본값은 false 입니다.
default.mov

문제 상황과 해결

  • 현재, fix props를 받아 variant를 통해 스타일링하고 있는데, vanila-extract에서 props를 이용한 conditional styling의 더 나은 방법이 있는지 확인하고 리팩토링하면 좋을 거 같습니다!

비고

@naro-Kim naro-Kim added the enhancement New feature or request label Jul 3, 2023
@naro-Kim naro-Kim changed the title feature/FE-052 : Input 컴포넌트 fixed Height helper text 대응 feature/FE-053 : Input 컴포넌트 fixed Height helper text 대응 Jul 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

sxungchxn
sxungchxn approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@sxungchxn sxungchxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@naro-Kim naro-Kim merged commit 426335b into dev Jul 4, 2023
3 checks passed
@naro-Kim naro-Kim deleted the feature/FE-053 branch July 4, 2023 15:23
@naro-Kim naro-Kim self-assigned this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxungchxn sxungchxn sxungchxn approved these changes

@jieunpark247 jieunpark247 Awaiting requested review from jieunpark247

Assignees

@naro-Kim naro-Kim

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naro-Kim @sxungchxn