Feature/FE-022 - 회원가입 페이지 / 웰컴 페이지 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
naro-Kim
approved these changes
Jul 1, 2023
naro-Kim
reviewed
Jul 1, 2023
There was a problem hiding this comment.
약관 동의 과정에서 누르지 않고 form을 submit한 경우, 동의 버튼이 disabled 되는 에러가 있는 것 같습니다.
추후 수정에 포함해야할 것 같습니다~
naro-Kim
reviewed
Jul 1, 2023
| return ( | ||
| <div className={wrapper}> | ||
| <Title textAlign="start">인증 메일을 보냈습니다.</Title> | ||
| <Typography as="p" variant="body2" className={description}> |
There was a problem hiding this comment.
현재는 @Samsung으로 주소가 표시되어있는데 '{${userInfo.email}@samsung.com} '로 표기해주어야 할 거 같습니다
naro-Kim
reviewed
Jul 1, 2023
| @@ -0,0 +1,21 @@ | |||
| import { keyframes, style } from '@vanilla-extract/css'; | |||
|
|
|||
| const fadeInAnimation = keyframes({ | |||
naro-Kim
reviewed
Jul 1, 2023
There was a problem hiding this comment.
저도 추가로 constants 폴더에 관리해보도록 하겠습니다~ 굿굿
naro-Kim
approved these changes
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
체크 리스트
작업 내역
비고