Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : profile 498 에러시 무한루프도는 현상 수정 #133

Merged
merged 4 commits into from
Aug 4, 2023
Merged

fix : profile 498 에러시 무한루프도는 현상 수정 #133

merged 4 commits into from
Aug 4, 2023

Conversation

jieunpark247
Copy link
Contributor

@jieunpark247 jieunpark247 commented Aug 3, 2023 •
edited
Loading

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 관련된 이슈와 연결 시켰나요?
  • Target Branch를 올바르게 설정했나요?
  • Label을 알맞게 설정했나요?

작업 내역

  • 로그인 무한루프 로직 수정
  • suspense 설정으로 인한 에러시 재요청이 일어나고 있음 -> useQuery로 변경 후 retry 0번으로 세팅 (Default:3)

문제 상황과 해결

아래와 같은 내용으로 협의 완료

  • BE에서 /refresh api에서 status: 400이 호출 되는 경우 refreshToken 삭제 요청
  • FE에서는 refreshToken만료시 profile(498) -> /refresh (400) -> profile (204) 순서로 호출

@sonarcloud
Copy link

sonarcloud bot commented Aug 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sxungchxn sxungchxn self-requested a review August 4, 2023 10:45
sxungchxn
sxungchxn approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@sxungchxn sxungchxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인증 로직 변경 수고하셨습니다!

@jieunpark247 jieunpark247 merged commit 495a200 into dev Aug 4, 2023
3 checks passed
@jieunpark247 jieunpark247 deleted the feature/FE-088 branch August 4, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxungchxn sxungchxn sxungchxn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jieunpark247 @sxungchxn