Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fe-091 상세페이지 QA 반영 #127

Merged
merged 10 commits into from
Jul 31, 2023
Merged

Feature/fe-091 상세페이지 QA 반영 #127

merged 10 commits into from
Jul 31, 2023

Conversation

sxungchxn
Copy link
Member

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 관련된 이슈와 연결 시켰나요?
  • Target Branch를 올바르게 설정했나요?
  • Label을 알맞게 설정했나요?

작업 내역

문제 상황과 해결

  • 모집 상태와 관련된 로직이 상당히 복잡하여 관련 훅을 정의하고 내부적으로 처리하도록 했습니다.

비고

@sxungchxn sxungchxn added 🐞 bug Something isn't working enhancement New feature or request labels Jul 30, 2023
@sxungchxn sxungchxn self-assigned this Jul 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

naro-Kim
naro-Kim approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@naro-Kim naro-Kim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

state별 분리 조건이 복잡했는데 hook으로 분리하신 것 잘 봤습니다!
고생하셨습니다 ~~!

@naro-Kim naro-Kim merged commit af22cc4 into dev Jul 31, 2023
3 checks passed
@naro-Kim naro-Kim deleted the feature/FE-091 branch July 31, 2023 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naro-Kim naro-Kim naro-Kim approved these changes

@jieunpark247 jieunpark247 Awaiting requested review from jieunpark247

Assignees

@sxungchxn sxungchxn

Labels
🐞 bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sxungchxn @naro-Kim