New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fe-079 : 페이지 전환 애니메이션 적용 #106

Merged

jieunpark247 merged 3 commits into dev from feature/FE-079

Jul 22, 2023

Contributor

naro-Kim commented Jul 21, 2023

체크 리스트

적절한 제목으로 수정했나요?
관련된 이슈와 연결 시켰나요?
Target Branch를 올바르게 설정했나요?
Label을 알맞게 설정했나요?

작업 내역

페이지 사이 전환 애니메이션을 적용했습니다.

문제 상황과 해결

flikering.mov

Skeleton이 적용된 페이지에 fade 애니메이션이 적용될 경우 깜빡거림이 발생해 적용에서 제외해두었습니다.

비고

PR을 하지 않은 생성 페이지는 현재 애니메이션을 적용 하지않은 상태입니다.
협의하에 애니메이션 적용 범위와 효과를 수정해야 할 것 같습니다.

naro-Kim added 3 commits

July 21, 2023 16:54


          style: animation style 추가

e848b42


          style: login page 애니메이션 적용

8b64391


          style: home page 애니메이션 적용

fdf930f

naro-Kim added the 🎨 design label

naro-Kim requested review from jieunpark247 and sxungchxn

July 21, 2023 08:10

naro-Kim self-assigned this

sonarcloud bot commented Jul 21, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

jieunpark247 approved these changes

View reviewed changes

Contributor

jieunpark247 left a comment

👍🏼

jieunpark247 merged commit 737a6ce into dev

3 checks passed

jieunpark247 deleted the feature/FE-079 branch

July 22, 2023 08:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels