-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TNT-181] 트레이니 홈 화면 일별 기록 출력 API 연동 #100
Conversation
- 디자인 변동 사항에 맞춰 피드백 개수가 아닌 여부를 받도록 수정
# Conflicts: # data/network/src/main/java/co/kr/data/network/model/trainee/DailyRecordResponse.kt # data/network/src/main/java/co/kr/data/network/service/ApiService.kt # data/network/src/main/java/co/kr/data/network/source/TraineeRemoteDataSource.kt # data/repository/src/main/java/co/kr/data/repository/TraineeRepositoryImpl.kt # domain/src/main/java/co/kr/tnt/domain/repository/TraineeRepository.kt # feature/trainee/home/src/main/java/co/kr/tnt/trainee/home/TraineeHomeScreen.kt
- recordType이 MealType 일때만 이동
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
val trainerName: String?, | ||
val trainerProfileImage: String?, | ||
val session: Int?, | ||
val lessonStart: String?, | ||
val lessonEnd: String?, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오잉 이건 왜 다 nullable
이 됐나요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
서버 response 따라가다보니 nullable
로 됐습니당.. 배포하고 다시 수정해야 할 것 같습니다!!!
modifier = Modifier | ||
.padding(start = 16.dp, end = 16.dp, bottom = 12.dp) | ||
.clickable { | ||
if (record.recordType is RecordType.MealType) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
식단 기록 아닌 타입도 클릭 활성화되는지 확인 필요할 것 같아용~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정상 작동합니다!
default.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 지금 상세 화면으로 안가지는게 맞는데 클릭 자체가 활성화되는게 맞나 해서요 '-'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
비활성화 되도록 수정했습니다
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
나중에 then
쓰게 수정하시죠 ㅋ_ㅋ 굳굳
📝 작업 내용
Closes [TNT-181] 트레이니의 일별 기록 출력 #44
주간 캘린더에서 선택한 날짜에 맞는 PT 수업과 기록 조회 API를 연동했습니다.
사용자가 날짜를 선택할 때마다 API를 호출해 해당 날짜의 수업 및 기록 데이터를 갱신하도록 구현했습니다.
+ 추가
선택된 날짜의 식단 기록을 누르면 식단 기록 확인 화면으로 이동하도록 구현했습니다.📸 실행 화면
TraineeDailyRecord.mp4
TraineeHomeToMealDetail.mp4
🙆🏻 리뷰 요청 사항
없습니다!
👀 레퍼런스