This repository has been archived by the owner on May 25, 2021. It is now read-only.
QuACS data source adapter, multisemester support, and bug fixes #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaterDrop 2.0 is backwards-incompatible with 1.*, so malg crashes without this.
io12
changed the title
The old banner adapter's upstream data is not being updated anymore. This new QuACS adapter allows YACS to get up-to-date data.
io12
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WaterDrop 2.0 is backwards-incompatible with 1.*, so malg crashes without explicitly using the older version.
Core-consumer assumes that karafka allows multiple topics for the same consumer, which isn't true with the current version. Fixing this allows multi-semester support to work.
Also, the old banner adapter's upstream data is not being updated anymore. This PR adds a new QuACS adapter allows YACS to get up-to-date data.