This repository has been archived by the owner on May 25, 2021. It is now read-only.
Added ability to copy schedule links #487
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually don't merge this yet. I just found an error that I need to fix |
|
alright now its fixed |
Bad-Science
reviewed
Sep 2, 2019
| /* TODO: schedule index setting is not yet implemented */ | ||
|
|
||
| let url: string = window.location.href; | ||
| let i1: number = url.indexOf('schedules?section_ids='); |
There was a problem hiding this comment.
I would suggest refactoring this to use https://angular.io/api/router/ActivatedRoute here before merging, I think it would make this code a lot cleaner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not fully working. But the basic functionality is here.
What is working:
What isn't working:
I don't know exactly how to fix this yet, but I do know the issue. The line that I need for setting the index isn't running when it needs to be run. I was able to fix this by putting in a timeout but that is way too slow. Going to expand on this later to add that functionality, but for now I feel it is more important to have at least this out there to be used.