[improve](group_commit) optimize group commit select be logic apache#…

…28190 Group commit choose be always first no decommissioned be in all be. Choose be with selectBackendIdsByPolicy like common stream load and do not choose decommissioned be may be better.
XuJianxu · Dec 14, 2023 · b0370dd · b0370dd
1 parent f6722f4
commit b0370dd
Showing 1 changed file with 10 additions and 11 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java b/fe/fe-core/src/main/java/org/apache/doris/httpv2/rest/LoadAction.java
@@ -335,25 +335,24 @@ private Object executeStreamLoad2PC(HttpServletRequest request, String db) {
     private TNetworkAddress selectRedirectBackend(String clusterName, boolean groupCommit) throws LoadException {
         Backend backend = null;
         BeSelectionPolicy policy = null;
+        String qualifiedUser = ConnectContext.get().getQualifiedUser();
+        Set<Tag> userTags = Env.getCurrentEnv().getAuth().getResourceTags(qualifiedUser);
+        policy = new BeSelectionPolicy.Builder()
+                .addTags(userTags)
+                .needLoadAvailable().build();
+        List<Long> backendIds = Env.getCurrentSystemInfo().selectBackendIdsByPolicy(policy, 1);
+        if (backendIds.isEmpty()) {
+            throw new LoadException(SystemInfoService.NO_BACKEND_LOAD_AVAILABLE_MSG + ", policy: " + policy);
+        }
         if (groupCommit) {
-            List<Long> allBackendIds = Env.getCurrentSystemInfo().getAllBackendIds(true);
-            for (Long backendId : allBackendIds) {
+            for (Long backendId : backendIds) {
                 Backend candidateBe = Env.getCurrentSystemInfo().getBackend(backendId);
                 if (!candidateBe.isDecommissioned()) {
                     backend = candidateBe;
                     break;
                 }
             }
         } else {
-            String qualifiedUser = ConnectContext.get().getQualifiedUser();
-            Set<Tag> userTags = Env.getCurrentEnv().getAuth().getResourceTags(qualifiedUser);
-            policy = new BeSelectionPolicy.Builder()
-                    .addTags(userTags)
-                    .needLoadAvailable().build();
-            List<Long> backendIds = Env.getCurrentSystemInfo().selectBackendIdsByPolicy(policy, 1);
-            if (backendIds.isEmpty()) {
-                throw new LoadException(SystemInfoService.NO_BACKEND_LOAD_AVAILABLE_MSG + ", policy: " + policy);
-            }
             backend = Env.getCurrentSystemInfo().getBackend(backendIds.get(0));
         }
         if (backend == null) {