Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intellij pop-ups appear in the wrong place sometimes #2008

Closed
totaam opened this issue Oct 25, 2018 · 9 comments
Closed

intellij pop-ups appear in the wrong place sometimes #2008

totaam opened this issue Oct 25, 2018 · 9 comments
Labels
bug Something isn't working client geometry
Milestone

Comments

@totaam
Copy link
Collaborator

totaam commented Oct 25, 2018

Issue migrated from trac ticket # 2008

component: java | priority: minor

2018-10-25 11:17:45: facboy created the issue


xpra occasionally lose track of where Intellij's pop-ups are supposed to appear. eg you right-click and the pop-up appears way over on the right of the screen instead of under the mouse. Resizing the window seems to fix it for a while.

I am running two monitors on the client if that makes a difference, and I have multiple intellij windows (different projects) open.

@totaam
Copy link
Collaborator Author

totaam commented Oct 28, 2018

I can't seem to be able to reproduce it.

@facboy: can you try this trivial patch:
[/attachment/ticket/1941/disable-pointer-adjustment.patch]? (more details in #1941)

If you can still reproduce it, maybe you can also capture the "-d metadata" client output?

@totaam
Copy link
Collaborator Author

totaam commented Nov 12, 2018

Without more details, I will have to close this as 'NEEDINFO', see ReportingBugs for generic guidelines.

@totaam
Copy link
Collaborator Author

totaam commented Jul 23, 2020

2020-07-23 18:11:07: bjcamp95 commented


Wanted to re-open this as it is happening to me, if i resize the window it resets correct until that window is hidden.
Im using I3, and it seems to be related to that possibly?

Here is what my metadata looked like for a few clicks and some fixing/unfixing

WRONG

2020-07-23 09:59:01,740 process_new_common: [43, 4907, 450, 377, 561, {b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x6006ba', b'title': b'win31', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601}], metadata={b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x6006ba', b'title': b'win31', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601}, OR=True
2020-07-23 09:59:01,741 update_metadata({b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x6006ba', b'title': b'win31', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601, b'size-constraints': {}})
2020-07-23 09:59:01,742 set_metadata({b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x6006ba', b'title': b'win31', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601, b'size-constraints': {}})
2020-07-23 09:59:01,742 apply_geometry_hints({b'max_width': 32767, b'max_height': 32767}) geometry=<Gdk.Geometry object at 0x7fc71c0e9f48 (void at 0x1a1f270)>, hints=<flags GDK_HINT_MAX_SIZE of type Gdk.WindowHints>
2020-07-23 09:59:01,746 metadata update for window 43: {b'above': True}
2020-07-23 09:59:01,746 update_metadata({b'above': True})
2020-07-23 09:59:01,746 set_metadata({b'above': True})


RESIZE

2020-07-23 09:59:13,749 metadata update for window 12: {b'iconic': False}
2020-07-23 09:59:13,749 update_metadata({b'iconic': False})
2020-07-23 09:59:13,749 set_metadata({b'iconic': False})
2020-07-23 09:59:14,771 metadata update for window 12: {b'iconic': True}
2020-07-23 09:59:14,771 update_metadata({b'iconic': True})
2020-07-23 09:59:14,771 set_metadata({b'iconic': True})


RIGHT

2020-07-23 09:59:23,217 process_new_common: [44, 3238, 321, 377, 561, {b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x6006fb', b'title': b'win32', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601}], metadata={b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x6006fb', b'title': b'win32', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601}, OR=True
2020-07-23 09:59:23,225 update_metadata({b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x6006fb', b'title': b'win32', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601, b'size-constraints': {}})
2020-07-23 09:59:23,227 set_metadata({b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x6006fb', b'title': b'win32', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601, b'size-constraints': {}})
2020-07-23 09:59:23,229 apply_geometry_hints({b'max_width': 32767, b'max_height': 32767}) geometry=<Gdk.Geometry object at 0x7fc71c0ee868 (void at 0x1995f00)>, hints=<flags GDK_HINT_MAX_SIZE of type Gdk.WindowHints>
2020-07-23 09:59:23,267 metadata update for window 44: {b'above': True}
2020-07-23 09:59:23,267 update_metadata({b'above': True})
2020-07-23 09:59:23,268 set_metadata({b'above': True})


WINDOW SWAP

2020-07-23 09:59:36,938 metadata update for window 12: {b'iconic': False}
2020-07-23 09:59:36,938 update_metadata({b'iconic': False})
2020-07-23 09:59:36,938 set_metadata({b'iconic': False})
2020-07-23 09:59:37,231 metadata update for window 10: {b'iconic': True}
2020-07-23 09:59:37,231 update_metadata({b'iconic': True})
2020-07-23 09:59:37,231 set_metadata({b'iconic': True})
2020-07-23 09:59:39,217 metadata update for window 10: {b'iconic': False}
2020-07-23 09:59:39,218 update_metadata({b'iconic': False})
2020-07-23 09:59:39,219 set_metadata({b'iconic': False})
2020-07-23 09:59:39,501 metadata update for window 12: {b'iconic': True}
2020-07-23 09:59:39,501 update_metadata({b'iconic': True})
2020-07-23 09:59:39,502 set_metadata({b'iconic': True})


WRONG AGAIN

2020-07-23 09:59:44,718 process_new_common: [45, 5042, 314, 377, 561, {b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x60070c', b'title': b'win33', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601}], metadata={b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x60070c', b'title': b'win33', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601}, OR=True
2020-07-23 09:59:44,720 update_metadata({b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x60070c', b'title': b'win33', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601, b'size-constraints': {}})
2020-07-23 09:59:44,720 set_metadata({b'window-type': (b'DIALOG',), b'override-redirect': True, b'xid': b'0x60070c', b'title': b'win33', b'skip-taskbar': True, b'transient-for': 10, b'class-instance': (b'jetbrains-idea', b'jetbrains-idea'), b'client-machine': b'dev-dsk-bencam-2a-2d2714d1.us-west-2.amazon.com', b'pid': 21508, b'group-leader-xid': 6291601, b'size-constraints': {}})
2020-07-23 09:59:44,721 apply_geometry_hints({b'max_width': 32767, b'max_height': 32767}) geometry=<Gdk.Geometry object at 0x7fc71c0f4228 (void at 0x1979000)>, hints=<flags GDK_HINT_MAX_SIZE of type Gdk.WindowHints>
2020-07-23 09:59:44,727 metadata update for window 45: {b'above': True}
2020-07-23 09:59:44,727 update_metadata({b'above': True})
2020-07-23 09:59:44,727 set_metadata({b'above': True})


This started happening after i changed new boxes and upgraded to 3.0.10-11 (running linux version derived from CENTOS 7) previously i was using 1.0.14 and it was working fine (running in a linux version derived from CENTOS 6)

@totaam
Copy link
Collaborator Author

totaam commented Jul 30, 2020

2020-07-30 18:24:10: bjcamp95 commented


Ive installed xpar 4 on both server and client, and im still getting this issue.

@totaam totaam added v3.0.x bug Something isn't working client geometry and removed v3.0.x labels Jan 22, 2021
@totaam totaam added this to the 4.2 milestone Jan 23, 2021
@stdedos
Copy link
Collaborator

stdedos commented Apr 30, 2021

It sounds like a duplicate of one of my tickets #2697

totaam added a commit that referenced this issue May 7, 2021
@totaam
Copy link
Collaborator Author

totaam commented May 7, 2021

I'm not sure if this is going to fix the popups, but the fix above ensures that the window is in the same place it was before when re-attaching to the same session.

totaam added a commit that referenced this issue May 7, 2021
totaam added a commit that referenced this issue May 7, 2021
@stdedos
Copy link
Collaborator

stdedos commented May 11, 2021

Using type hints for monitor placement breaks the libreoffice popups.

Unless I need both server and client on the same version for this to work 😕

totaam added a commit that referenced this issue May 11, 2021
don't use the 0,0 position size hint if we have a more usable initial window position
@totaam
Copy link
Collaborator Author

totaam commented May 11, 2021

Using type hints for monitor placement breaks the libreoffice popups.

Ah, indeed it does. They set an invalid position size-hint of 0,0.
The commit above should be more correct.

totaam added a commit that referenced this issue May 11, 2021
totaam added a commit that referenced this issue May 11, 2021
don't use the 0,0 position size hint if we have a more usable initial window position
totaam added a commit that referenced this issue May 11, 2021
don't use the 0,0 position size hint if we have a more usable initial window position
@stdedos
Copy link
Collaborator

stdedos commented May 11, 2021

Ah, indeed it does. They set an invalid position size-hint of 0,0.

Funny thing that people do wrong things to arrive to the correct result 😝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client geometry
Projects
None yet
Development

No branches or pull requests

2 participants