Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tc cross epoch different masternode counts issue #770

Conversation

benjamin202410
Copy link
Collaborator

@benjamin202410 benjamin202410 commented Dec 23, 2024

Proposed changes

Fix tc cross epoch different masternode counts issue

Root Cause

Found out by testnet issue, node start sending sync info message, because one of node not functioning (normal). And Sync Info Message contains latest TC and QC. But TC is generated by last epoch which only have 17 signatures but current epoch requires 19 signatures. So sync info is not accepting by all the nodes. Cause some nodes are at old round and some nodes are at new round.

Fix

When process TC, it should use the right epoch information, not the current epoch / round information.

Side Fix

When send timeout message, node also save timeout message into local pool, and we have XDPoS_getLatestPoolStatus to receive signer. But we only assign signer while verify incoming timeout.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@AnilChinchawale AnilChinchawale merged commit b2a41af into release-br-v2.4.5-beta1 Dec 23, 2024
34 checks passed
@benjamin202410 benjamin202410 deleted the fix-tc-cross-epoch-different-masternode-counts-issue branch December 23, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants