Fix tc cross epoch different masternode counts issue #770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix tc cross epoch different masternode counts issue
Root Cause
Found out by testnet issue, node start sending sync info message, because one of node not functioning (normal). And Sync Info Message contains latest TC and QC. But TC is generated by last epoch which only have 17 signatures but current epoch requires 19 signatures. So sync info is not accepting by all the nodes. Cause some nodes are at old round and some nodes are at new round.
Fix
When process TC, it should use the right epoch information, not the current epoch / round information.
Side Fix
When send timeout message, node also save timeout message into local pool, and we have XDPoS_getLatestPoolStatus to receive signer. But we only assign signer while verify incoming timeout.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅
in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅
in the boxes that applyChecklist
Put an
✅
in the boxes once you have confirmed below actions (or provide reasons on not doing so) that