fix: reduce mine period reset (waiting) time #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -290,6 +291,7 @@ func (self *worker) update() { | |||
| } | |||
| }() | |||
| for { | |||
| prevReset0TimeMillisec := int64(0) | |||
There was a problem hiding this comment.
This is called by value not a pointer/reference.
There was a problem hiding this comment.
changed to by pointer
miner/worker.go
Outdated
| // in case it resets to 0 in one millisecond too many times, we wait for mine period | ||
| resetTime = minePeriodDuration | ||
| } else { | ||
| prevReset0TimeMillisec = nowTime |
There was a problem hiding this comment.
prevReset0TimeMillisec won't got reserved as this is called by value.
wgr523
force-pushed
the
gerui-master-reduce_mine_reset
branch
from
502edac to
fb82016
Compare
liam-lai
approved these changes
Nov 19, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request.
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which part of the codebase this PR will touch base on,
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that