Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable on xdcx receiver part #521

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Disable on xdcx receiver part #521

merged 2 commits into from
Apr 19, 2024

Conversation

liam-lai
Copy link
Collaborator

@liam-lai liam-lai commented Apr 15, 2024

Proposed changes

Disable on xdcx receiver part. I didnt' modify all IsTIPXDCX to IsTIPXDCXReceiver condition as if it's reading the state, I think we better still let client be able to read the last state as it is actual state anyhow. Apply IsTIPXDCXReceiver on all incoming transactions.

Needs to test on devnet / testnet/ mainnet to perform fully resync.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@liam-lai liam-lai merged commit ef4b8ef into dev-upgrade Apr 19, 2024
34 checks passed
@liam-lai liam-lai deleted the xdcx-receiver branch April 19, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants