Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timeout too fast issue #393

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix timeout too fast issue #393

merged 1 commit into from
Jan 16, 2024

Conversation

liam-lai
Copy link
Collaborator

@liam-lai liam-lai commented Jan 16, 2024

Proposed changes

On devnet, 10 second timeout is too fast when there is heavy disk reading operation when receive/mine Epoch Block. Sometimes if disk performance is bad or no cache in the memory (reboot). Then it may occur timeout and round bump before sending Vote.

On the other words: Block takes x second to be generated from miner and takes y second to consume to others. If x + y > 10, then timeout trigger, round++, then this block won't treat as valid.

WARN [01-16|07:09:22] Failed to pass the voting rule verification, blockRound is not equal currentRound x.currentRound=7954010 blockInfo.Round=7954009

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

@liam-lai liam-lai merged commit c36df9f into dev-upgrade Jan 16, 2024
2 checks passed
@liam-lai liam-lai deleted the fix-timeout-too-fast branch January 16, 2024 10:49
@liam-lai liam-lai mentioned this pull request Feb 4, 2024
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants