API GetTransactionProof, GetReceiptProof

[wgr523]

No description provided.

[GalaxySciTech]

it need a test script

[liam-lai]

Yes, please write a test for proofPairList object and deriveTrie function at least

[wanwiset25]

do we need to put something in web3ext.go for external interface?
something like the below
new web3._extend.Method({ name: 'getV2Block', call: function (args) { return (web3._extend.utils.isString(args[0]) && args[0].indexOf('0x') === 0) ? "XDPoS_getV2BlockByHash" : "XDPoS_getV2BlockByNumber"; }, params: 1, inputFormatter: [web3._extend.formatters.inputBlockNumberFormatter]

[GalaxySciTech]

i think it is necessary to call GetReceiptProof function in test script

we need test the function

[wgr523]

I don't know how to write test for calling function like GetReceiptProof or other GetXXX. In the codebase I cannot find any test like this.

[GalaxySciTech]

if use that way how do we ensure the getReceiptProof will no error when we changed some code

[wgr523]

actually I don't know. I can only say that in our codebase (and the ethereum codebase xinfin forked) there is no test for api functions. So it is hard to write test for this api function GetReceiptProof

[GalaxySciTech]

it seems Receipt need to add a parameter contractAddress in here

XDC-Subnet/core/types/receipt.go

Line 99 in 3643104

return rlp.Encode(w, &receiptRLP{r.statusEncoding(), r.CumulativeGasUsed, r.Bloom, r.Logs})

[wgr523]

it seems Receipt need to add a parameter contractAddress in here

XDC-Subnet/core/types/receipt.go

Line 99 in 3643104

return rlp.Encode(w, &receiptRLP{r.statusEncoding(), r.CumulativeGasUsed, r.Bloom, r.Logs})

This encoding is written by ethereum yellow paper and I think we should not change it. If we change it, then our code is quite different from ethereum and users may not like it.

The code to compute contractAddress is quite simple and we can compute it whenever we want to use it: in core/state_processor.go

	// if the transaction created a contract, store the creation address in the receipt.
	if msg.To() == nil {
		receipt.ContractAddress = crypto.CreateAddress(vmenv.Context.Origin, tx.Nonce())
	}

(vmenv.Context.Origin is just tx.Sender())

[GalaxySciTech]

it seems Receipt need to add a parameter contractAddress in here

XDC-Subnet/core/types/receipt.go

Line 99 in 3643104

return rlp.Encode(w, &receiptRLP{r.statusEncoding(), r.CumulativeGasUsed, r.Bloom, r.Logs})

This encoding is written by ethereum yellow paper and I think we should not change it. If we change it, then our code is quite different from ethereum and users may not like it.

The code to compute contractAddress is quite simple and we can compute it whenever we want to use it: in core/state_processor.go

	// if the transaction created a contract, store the creation address in the receipt.
	if msg.To() == nil {
		receipt.ContractAddress = crypto.CreateAddress(vmenv.Context.Origin, tx.Nonce())
	}

(vmenv.Context.Origin is just tx.Sender())

i can only get the receiptrlp

the struct only have status bloom log gas

i can not get other parameters

[GalaxySciTech]

i think if any possible we can implement the eth_getProof function?
this is the reference https://eips.ethereum.org/EIPS/eip-1186

[wgr523]

i think if any possible we can implement the eth_getProof function? this is the reference https://eips.ethereum.org/EIPS/eip-1186

I find the implementation and can do it. But may I ask when do we need eth_getProof? I thought we only need transaction proof and receipt proof.

[GalaxySciTech]

i think if any possible we can implement the eth_getProof function? this is the reference https://eips.ethereum.org/EIPS/eip-1186

I find the implementation and can do it. But may I ask when do we need eth_getProof? I thought we only need transaction proof and receipt proof.

just forget it , this one just is a another way that deal the cross chain system