AIRCC: Remove experimental passes from aircc.py #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver airrt affine loop tiling
fifield
approved these changes
Feb 22, 2025
Comment on lines
48
to
+53
| verbose=False, | ||
| experimental_passes=False, | ||
| omit_while_true_loop=False, | ||
| omit_pingpong=False, | ||
| lower_linalg_to_func=False, | ||
| air_loop_fusion=False, | ||
| runtime_loop_tiling_sizes: list[int] = [4, 4], |
There was a problem hiding this comment.
We got rid of one option but grew some new ones :/
There was a problem hiding this comment.
Yeah... But the good thing is that they now more clearly specify what "experimental" features were being used. The lower_linalg_to_func is likely to be necessary to say if we want micro-kernel or direct code-generated (scalar, for now) code.
I wish the air-loop-fusion and runtim-loop-tiling-sizes can go eventually...
erwei-xilinx
deleted the
move_experimental_passes_to_default_npu_passes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those passes are now default passes for npu.
Also added a number of flags to control whether some passes get called.