Copy attributes from the original operation (SCF::ForOp) into the low…

…ered version (Emitc::ForOp) (#390)
Xilinx · Oct 22, 2024 · 4b36487 · 4b36487
1 parent 2015abf
commit 4b36487
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/mlir/lib/Conversion/SCFToEmitC/SCFToEmitC.cpp b/mlir/lib/Conversion/SCFToEmitC/SCFToEmitC.cpp
@@ -118,6 +118,9 @@ ForLowering::matchAndRewrite(ForOp forOp, OpAdaptor adaptor,
   emitc::ForOp loweredFor = rewriter.create<emitc::ForOp>(
       loc, adaptor.getLowerBound(), adaptor.getUpperBound(), adaptor.getStep());
 
+  // Propagate any attributes from the ODS forOp to the lowered emitc::for op.
+  loweredFor->setAttrs(forOp->getAttrs());
+
   Block *loweredBody = loweredFor.getBody();
 
   // Erase the auto-generated terminator for the lowered for op.

diff --git a/mlir/test/Conversion/SCFToEmitC/for.mlir b/mlir/test/Conversion/SCFToEmitC/for.mlir
@@ -98,3 +98,12 @@ func.func @nested_for_yield(%arg0 : index, %arg1 : index, %arg2 : index) -> f32
 // CHECK-NEXT:    }
 // CHECK-NEXT:    return %[[VAL_4]] : f32
 // CHECK-NEXT:  }
+
+func.func @loop_with_attr(%arg0 : index, %arg1 : index, %arg2 : index) {
+  scf.for %i0 = %arg0 to %arg1 step %arg2 {
+    %c1 = arith.constant 1 : index
+  } {test.value = 5 : index}
+  return
+}
+// CHECK-LABEL: func.func @loop_with_attr
+// CHECK: {test.value = 5 : index}