Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Clean up DRM FDs before PCI rescan post axlf load #8753

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

karthdmg-xilinx
Copy link
Collaborator

Problem solved by the commit

AWS performs a pci rescan to change the PCI device ID during the first image load.
If there are any references to DRM render files which are not closed during the pci rescan,
XRT driver hangs waiting for ever to get the driver instance closed which usually happens if the DRM FDs are closed.

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

XRT hangs indefinity in AWS environment during the PCI rescan after axlf load.

How problem was solved, alternative solutions (if any) and why they were rejected

Fix is to close all the opened DRM render FDs below the PCI rescan is issued.

Risks (if any) associated the changes in the commit

This is AWS specific change, would not impact other cards.

What has been tested and how, request additional testing if necessary

Ran RTL kernel APP to see the all the FDs are closed before PCI rescan, no hang observed.

Documentation impact (if any)

NA

Signed-off-by: karthik dmg <karthdmg@amd.com>
Signed-off-by: karthik dmg <karthdmg@amd.com>
@chvamshi-xilinx chvamshi-xilinx merged commit e4ace94 into Xilinx:2024.1 Feb 12, 2025
13 of 19 checks passed
chvamshi-xilinx pushed a commit that referenced this pull request Feb 20, 2025
* XRT changes w.r.to changes made in AWS library (#8646)

* Fix errors in PR 8361

* porting AWS F2 work around changes to 2024.1

Signed-off-by: karthik dmg <karthdmg@amd.com>

* changes related to latest AWS libirary update

Signed-off-by: karthik dmg <karthdmg@amd.com>

---------

Signed-off-by: karthik dmg <karthdmg@amd.com>
Co-authored-by: rave <karthik>

* resetting aws clocking module using AWS API (#8719)

Signed-off-by: karthik dmg <karthdmg@amd.com>

* Run clock reset functionality asynchronously (#8725)

Signed-off-by: karthik dmg <karthdmg@amd.com>

* Update ROM VBNV name by reading shell version from AWS interface (#8728)

Signed-off-by: karthik dmg <karthdmg@amd.com>

* AWS: Clean up DRM FDs before PCI rescan post axlf load (#8753)

* AWS: Clean up DRM FDs before PCI rescan post axlf load

Signed-off-by: karthik dmg <karthdmg@amd.com>

* removed debug print

Signed-off-by: karthik dmg <karthdmg@amd.com>

---------

Signed-off-by: karthik dmg <karthdmg@amd.com>

* Porting AWS PCI ID changes to 2024.2

Signed-off-by: karthik dmg <karthdmg@amd.com>

---------

Signed-off-by: karthik dmg <karthdmg@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants