Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XDP] First cut implementation of AIE Debug feature for all devices #8701

Merged
merged 63 commits into from
Jan 24, 2025
Merged

[XDP] First cut implementation of AIE Debug feature for all devices #8701

merged 63 commits into from
Jan 24, 2025

Conversation

pgschuey
Copy link
Collaborator

Problem solved by the commit

  • Observability is needed to see the configurations of AI Engines

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

  • None

How problem was solved, alternative solutions (if any) and why they were rejected

  • Expanded capabilities of AIE Debug plugin and supporting writer

Risks (if any) associated the changes in the commit

  • Lots of file changes

What has been tested and how, request additional testing if necessary

  • Compiled on client and VE2
  • Tested on vck190 and vek280

Documentation impact (if any)

  • Internal feature for now

Paul Schumacher and others added 30 commits October 15, 2024 15:48
initial debug plugin changes
84e8de8 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
header fixes
f4efa88 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
fixed compilation issues
7ea81b3 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@predutta
AIE Debug Plugin Edge implementation
47f393c 
Signed-off-by: Prerona Dutta <predutta@amd.com>
@predutta
AIE Debug Plugin Edge implementation with necesssary hooks
c6153a5 
Signed-off-by: Prerona Dutta <predutta@amd.com>
@predutta
Resolving hw_emu related linking issues
97cc763 
Signed-off-by: Prerona Dutta <predutta@amd.com>
@predutta
Fixing Seg fault and populating register issues
df3afdc 
Signed-off-by: Prerona Dutta <predutta@amd.com>
@predutta
Adding capability to specify register names
ca49669 
Signed-off-by: Prerona Dutta <predutta@amd.com>
@predutta
Adding python script to populate register name to value map for writer
7eb5310 
Signed-off-by: Prerona Dutta <predutta@amd.com>
@predutta
adding writer
b5422ad 
Signed-off-by: Prerona Dutta <predutta@amd.com>
@predutta
Adding code for writer and some refactoring
ee3df7a 
Signed-off-by: Prerona Dutta <predutta@amd.com>
@predutta
Removing AIE4 and adding TODO comments
3ae4300 
Signed-off-by: Prerona Dutta <predutta@amd.com>
initial improvements
bd9aaaa 
Signed-off-by: Schumacher <schuey@amd.com>
merge of master
459fa94 
Signed-off-by: Schumacher <schuey@amd.com>
cleaned up generations subdir
f7e801c 
Signed-off-by: Schumacher <schuey@amd.com>
compile fixes
5a3e559 
Signed-off-by: Schumacher <schuey@amd.com>
more compile corrections
50ab298 
Signed-off-by: Schumacher <schuey@amd.com>
Fixing mismatched data type in edge/poll()
198dcff
removed debug messages and default is all
a8e947b 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
streamlined code
720f17b 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
temp debug messages
000e76e 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
fixed bug
1febfe0 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
debugging
e80308b 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
fixed bug
a62d531 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
moved code around
1d3fb94 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
fixes with Prerona
5491a41 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
bug fix
20a170e 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
const char now string
cc2096e 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
bug fixes in database & writer
b9de87c 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
fixed order bug
29a5f61 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
predutta and others added 11 commits January 14, 2025 14:52
@predutta
fixing bug
ca88286 
Signed-off-by: Prerona Dutta <predutta@amd.com>
merge with master
b1a1f26 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
updated headers and register sets
4b6630c 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Minor bug fixes
68bf579
removed a lot of uuuuunnecessary regs
e89bd1f 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Fixing bugs in aie_debug/writer
a06d419
Resolve conflicts
a2aae7d
client improvements
f9ee9c9 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@vipangul
Successful client build
6aa7c46 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
updated writer
bd255c3 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
writer and bit width updates
46f5004 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@pgschuey pgschuey requested a review from predutta January 17, 2025 21:39
Paul Schumacher and others added 10 commits January 17, 2025 22:05
removed driver include and native x86 builds for debug plugin
d20ffa5 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@vipangul
PASS: Client build
b4f1ca9 
Signed-off-by: Vinod Pangul <146476973+vipangul@users.noreply.github.com>
@vipangul
Merge branch 'brAieDebugPlugin' of https://github.com/pgschuey/XRT in…
6699fd8 
…to brAieDebugPlugin
added back driver include
d72319d 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
updated comments in cmake files
37d4872 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@vipangul
Merge branch 'brAieDebugPlugin' of https://github.com/pgschuey/XRT in…
3ef6c75 
…to brAieDebugPlugin
cleanup of branch
8cab2ab 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
DCO Remediation Commit for Snigdha Gupta <snigupta@xsjsnigupta40x.xln…
2ec3902 
…x.xilinx.com>

I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: 198dcff
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: 1d797c6
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: 85017b1
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: 7e44a7b
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: 4d58363
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: f5ecbfc
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: 4a0ae01
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: f9e83bf
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: 68bf579
I, Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>, hereby add my Signed-off-by to this commit: a06d419

Signed-off-by: Snigdha Gupta <snigupta@xsjsnigupta40x.xlnx.xilinx.com>
build AIE debug for VE2
f44d5fb 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
Merge branch 'master' of https://github.com/Xilinx/XRT into brAieDebu…
bdd2a3e 
…gPlugin
jvillarre
jvillarre approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@jvillarre jvillarre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Known issues discussed internally to be addressed in future pull requests.

@jvillarre jvillarre merged commit 81ca1b7 into Xilinx:master Jan 24, 2025
20 checks passed
rchane pushed a commit to rchane/XRT that referenced this pull request Jan 24, 2025
@pgschuey @rchane
[XDP] First cut implementation of AIE Debug feature for all devices (X…
b667ded 
…ilinx#8701)
@parthash0804 parthash0804 mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillarre jvillarre jvillarre approved these changes

@predutta predutta Awaiting requested review from predutta

@chvamshi-xilinx chvamshi-xilinx Awaiting requested review from chvamshi-xilinx chvamshi-xilinx is a code owner

@stsoe stsoe Awaiting requested review from stsoe stsoe is a code owner

@rozumx rozumx Awaiting requested review from rozumx rozumx is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgschuey @jvillarre @predutta @vipangul