Bug fix in getting AIE clock frequency using xbutil advanced. #8203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the sub commands Signed-off-by: Manoj Takasi <mtakasi@amd.com>
ManojTakasi
requested review from
rozumx,
chvamshi-xilinx and
AShivangi
as code owners
AShivangi
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
CR-1197325 getting/setting AIE clock frequency is an suboption in the of xbutil advanced command. xbutil advanced --aie-clock -g is always hitting the printHelp() function as it is m_device as an empty string.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
How problem was solved, alternative solutions (if any) and why they were rejected
Removed m_device as it's mentioned in both options and sub options.
Risks (if any) associated the changes in the commit
NA
What has been tested and how, request additional testing if necessary
Teseted with VCK190.
Documentation impact (if any)
NA