Fix boost library link issue when using static boost #8193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbramand <rbramand@amd.com>
rbramand-xilinx
requested review from
chvamshi-xilinx
and removed request for
rozumx
|
Added do not merge label as this PR needs to be merged post 2024.1 release |
stsoe
approved these changes
May 22, 2024
|
Hi @chvamshi-xilinx, as 2024.1 branched out I have removed do not merge label. Please review and merge this PR |
chvamshi-xilinx
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
When using boost static build the package generated still has dependency on boost dynamic library (eg: libboost_system.so)
added changes to fix this issue
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Issue raised by customer
How problem was solved, alternative solutions (if any) and why they were rejected
Added boost static libraries path to the search path for libraries using link_directories
This way required static boost library is found when target_link_libraries is used and wrong dependency is not added
Ideal fix would be to remove boost_system dependency as we have moved to std::filesystem and this lib dependency is not needed any more. Same fix has been sent to master. But to keep things simpler going through this route
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested dependencies on xrt packages generated and dependencies are as expected
Documentation impact (if any)
NA