Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed all names from XDP_MINIMAL_BUILD to XDP_CLIENT_BUILD #7893

Merged
merged 2 commits into from
Jan 23, 2024

Conversation

nishraptor
Copy link
Collaborator

Problem solved by the commit

Renamed XDP_MINIMAL_BUILD to XDP_CLIENT_BUILD

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

Naming update for XDP plugins

What has been tested and how, request additional testing if necessary

Tested when building for client to verify dll's were generated correctly

…ted directory names

Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Jan 18, 2024

Build failed :(

Copy link
Collaborator

@stsoe stsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for XRT-MCDM and XRT-IPU. I suggest that immediately after this PR is merged, you create a PR to update XRT on both XRT-MCDM and XRT-IPU. Thanks!

@dayeh-xilinx
Copy link

retest this please.

@nishraptor
Copy link
Collaborator Author

@stsoe There were two XDP_MINIMAL_BUILD variables. The first is a CMake Variable, set by XRT-IPU, and the second is a compile-time variable only set if the CMake variable is on. I've only changed the compile-time variable to XDP_CLIENT_BUILD, so the CMake variable should be still called XDP_MINIMAL_BUILD. I don't believe anything should break in the IPU branches from this change.

@gbuildx
Copy link
Collaborator

gbuildx commented Jan 22, 2024

Build Passed!

…ositories.

Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
@nishraptor nishraptor requested a review from stsoe January 23, 2024 17:17
@nishraptor
Copy link
Collaborator Author

@stsoe After conversation with @jvillarre, we have decided to rename the CMake Variable as well. I will create pull requests in XRT-IPU and XRT-MCDM as well to change the CMake variable name and update the xrt commit. This will have to be done after this PR is merged.

@gbuildx
Copy link
Collaborator

gbuildx commented Jan 23, 2024

Build failed :(

@dayeh-xilinx
Copy link

retest this please.

@gbuildx
Copy link
Collaborator

gbuildx commented Jan 23, 2024

Build Passed!

@jvillarre jvillarre merged commit 50f17b1 into Xilinx:master Jan 23, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants