fixing crash in xbmgmt/xbutil examine #7890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Passed! |
|
@dbenusov-xilinx , Merging this PR as lot of failures in sprite. Will address any of your review comments in next PR. |
|
Thanks for fixing this. It looks good to me, though I would now probably like to replace the vector with a map so it is easier to handle these types of cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
xbutil/xbmgmt examine is crashing with latest XRT. This happens only for golden images case.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
#7870 introduced this bug. Sprite caught this issue
How problem was solved, alternative solutions (if any) and why they were rejected
Fixed the newly added code. Throwing proper error message
Risks (if any) associated the changes in the commit
None
What has been tested and how, request additional testing if necessary
Verified the overall flow
Documentation impact (if any)
None