Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial support for tracing DMA events in AIE tile memory modules #7859

Merged
merged 16 commits into from
Jan 30, 2024
Merged

Initial support for tracing DMA events in AIE tile memory modules #7859

merged 16 commits into from
Jan 30, 2024

Conversation

pgschuey
Copy link
Collaborator

Problem solved by the commit

  • We have not monitored events in memory modules, only broadcasted core module events

How problem was solved, alternative solutions (if any) and why they were rejected

  • Added initial support for DMA events from memory modules
  • Added supporting functionality to enable DMA events (e.g., combo events, stream switch event ports)

Risks (if any) associated the changes in the commit

  • First time using combo events
  • Some new metric sets may lead to overruns for complex designs

What has been tested and how, request additional testing if necessary

  • Tested on vck190 and vek280

Documentation impact (if any)

  • Changes in two metric set names (potentially deprecating old ones in 2024.2)
  • Mention new metric sets once verified and approved

Paul Schumacher added 8 commits December 12, 2023 14:43
first cut expanded AIE tile metric sets
3457492 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
improved combo events
65c0f99 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
fixed runtime error in combo event
6a3b059 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
fixed some bugs
4233b2a 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
corrected messages
6862572 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
merge from master
4ead86c 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
corrected windows warning
6437a2c 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
corrected bugs with DMA trace config
05e25ce 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@pgschuey pgschuey requested a review from jvillarre as a code owner December 19, 2023 23:31
@pgschuey pgschuey marked this pull request as draft December 19, 2023 23:31
added support for DMA-only tiles in trace
a3ce366 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Dec 20, 2023

Build Passed!

Paul Schumacher added 2 commits December 21, 2023 15:47
added edge event support for AIE tiles
11fda1c 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
fixed windows compile issue
1cce2a6 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Dec 22, 2023

Build Passed!

fixed s2mm event bug
b477f20 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@pgschuey pgschuey marked this pull request as ready for review January 12, 2024 21:34
@gbuildx
Copy link
Collaborator

gbuildx commented Jan 12, 2024

Build Passed!

@gbuildx
Copy link
Collaborator

gbuildx commented Jan 20, 2024

Build failed :(

revert x86 and win changes
e8803c0 
Signed-off-by: Paul Schumacher <schuey@xilinx.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Jan 23, 2024

Build Passed!

@jvillarre jvillarre merged commit a3bc07d into Xilinx:master Jan 30, 2024
20 checks passed
@pgschuey pgschuey deleted the aie_trace_all branch March 5, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillarre jvillarre jvillarre approved these changes

@nishraptor nishraptor Awaiting requested review from nishraptor

@hackwa hackwa Awaiting requested review from hackwa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgschuey @gbuildx @jvillarre