Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIE Profile Update to maintain equivalence between Edge/Client #7852

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

nishraptor
Copy link
Collaborator

Problem solved by the commit

We now parse the same metricsets and modify events in the same location for edge and client.

How problem was solved, alternative solutions (if any) and why they were rejected

  • We now initialize client events using the same functions in aie_profile_util.cpp just like the edge implementation. Moved the modifyEvents function to the util class and fixed an issue where interface tile events were incorrectly modified by default.
  • Also fixed issue with the "schema" missing in new aie_control_config files. We now look for the aiecompiler_options field instead. This will need to be modified at a later date
  • Metricsets for input and output stalls in interface tiles for AIE1 were using AIE2 events, and thus were invalid. For AIE1 devices, these events have been changed to use AIE1 events.

Risks (if any) associated the changes in the commit

What has been tested and how, request additional testing if necessary

Tested on client device

Documentation impact (if any)

…util.cpp just like the edge implementation. Moved the modifyEvents function to the util class and fixed an issue where interface tile events were incorrectly modified by default

Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
…ntrol_config.json. We now check aiecompiler_options setting in order to check if the aie_control_config.json filetype exists

Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
Signed-off-by: Nishant Mysore <nishraptor@gmail.com>
@gbuildx
Copy link
Collaborator

gbuildx commented Dec 15, 2023

Build Passed!

@jvillarre jvillarre merged commit f0f31af into Xilinx:master Dec 15, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants