Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for CR-1183009 mem-bw test failing without platform.json #7847

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

rchane
Copy link
Collaborator

@rchane rchane commented Dec 13, 2023

Problem solved by the commit

https://jira.xilinx.com/browse/CR-1183009

Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered

#7746 introduced the bug.

How problem was solved, alternative solutions (if any) and why they were rejected

We will use runTestCase from TestRunner (what we used to do before PR 7746) when we see that there is no platform.json in mem-bw. runTestCase has been simplified to be runPyTestCase, as it is only used to run py test for this situation. Removed the busybar from runScript as the busybar is now started at a higher level in TestRunner.

Risks (if any) associated the changes in the commit

N/A

What has been tested and how, request additional testing if necessary

Testing on u250, CR poster's machine

rchane@xcosda156:/scratch/rchane/temp/xrt/bin$ ./xbutil examine
WARNING: Unexpected xocl version (2.17.98) was found. Expected 2.17.0, to match XRT tools.
System Configuration
  OS Name              : Linux
  Release              : 5.15.0-87-generic
  Version              : #97-Ubuntu SMP Mon Oct 2 21:09:21 UTC 2023
  Machine              : x86_64
  CPU Cores            : 12
  Memory               : 46719 MB
  Distribution         : Ubuntu 22.04.2 LTS
  GLIBC                : 2.35
  Model                : PowerEdge R740
  BIOS vendor          : Dell Inc.
  BIOS version         : 2.3.10

XRT
  Version              : 2.17.0
  Branch               : Fix-CR-1183009
  Hash                 : c2f98bd9ed1df10355d841e5e3df1e2d385cea9e
  Hash Date            : 2023-12-13 13:49:00
  XOCL                 : 2.17.98, ea1043caf175630f2bd8c3c63cc97c0e0fdf6841
  XCLMGMT              : 2.17.98, ea1043caf175630f2bd8c3c63cc97c0e0fdf6841

Devices present
BDF             :  Shell                               Logic UUID                            Device ID       Device Ready*
----------------------------------------------------------------------------------------------------------------------------
[0000:3b:00.1]  :  xilinx_u250_gen3x16_xdma_shell_2_1  C3AD6B03-7144-8CA9-494E-D5B672C7092A  user(inst=128)  Yes


* Devices that are not ready will have reduced functionality when using XRT tools
rchane@xcosda156:/scratch/rchane/temp/xrt/bin$ ./xbutil validate -d 3b:00 -r mem-bw
WARNING: Unexpected xocl version (2.17.98) was found. Expected 2.17.0, to match XRT tools.
Validate Device           : [0000:3b:00.1]
    Platform              : xilinx_u250_gen3x16_xdma_shell_2_1
    SC Version            : 4.5
    Platform ID           : C3AD6B03-7144-8CA9-494E-D5B672C7092A
-------------------------------------------------------------------------------
Verbose: Enabling Verbosity
Test 1 [0000:3b:00.1]     : mem-bw
    Description           : Run 'bandwidth kernel' and check the throughput
    Xclbin                : /opt/xilinx/firmware/u250/gen3x16/xdma-shell/test
    Testcase              : /opt/xilinx/xrt/test/23_bandwidth.py
    Details               : Maximum throughput: 52096 MB/s
    Test Status           : [PASSED]
-------------------------------------------------------------------------------
Validation completed

Documentation impact (if any)

N/A

@gbuildx
Copy link
Collaborator

gbuildx commented Dec 14, 2023

Build Passed!

@chvamshi-xilinx chvamshi-xilinx merged commit 556c23d into Xilinx:master Dec 14, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants