This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: use member func instead of macro RPC_CHECK_STATUS #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
previously approved these changes
Aug 21, 2020
acelyc111
previously approved these changes
Aug 22, 2020
neverchanje
reviewed
Aug 24, 2020
src/meta/meta_service.h
Outdated
Comment on lines
204
to
206
| template <typename TRespType> | ||
| bool check_status_with_msg(message_ex *req, TRespType response_struct); | ||
|
|
There was a problem hiding this comment.
Suggested change
| template <typename TRespType> | |
| bool check_status_with_msg(message_ex *req, TRespType response_struct); | |
| template <typename T, typename TRespType=std::remove_reference<T>::type> | |
| bool check_status_with_msg(message_ex *req, /*out*/ TRespType& response_struct); |
response_struct is declared as a value type. While the compiler likely treated it as a reference type, it's still very dangerous.
acelyc111
approved these changes
Aug 25, 2020
neverchanje
approved these changes
Aug 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous implementation, we use
RPC_CHECK_STATUSto check the status of meta server. But In cpp, macro has no type check, so we can't prevent it from calling withrpc_holder. But it will cause the response to be sent repeatedly if we do this.So in this pull request, I reimplement it using member function(function has type check).
I name this function as
check_status_with_msg, but notcheck_status, because it may produce template function instantiated with ambiguity if we usecheck_status.