This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(bulk-load): sync bulk load from remote storage #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Jul 13, 2020
levy5307
reviewed
Jul 13, 2020
neverchanje
reviewed
Jul 13, 2020
neverchanje
previously approved these changes
Jul 13, 2020
acelyc111
reviewed
Jul 13, 2020
| if (flag && children.size() > 0) { | ||
| ddebug_f("There are {} apps need to sync bulk load status", children.size()); | ||
| for (const auto &elem : children) { | ||
| uint32_t app_id = boost::lexical_cast<uint32_t>(elem); |
There was a problem hiding this comment.
boost::lexical_cast will throw exception when cast failed, are you sure the cast always success for elem?
There was a problem hiding this comment.
Yes, elem is app_id
neverchanje
approved these changes
Jul 14, 2020
acelyc111
approved these changes
Jul 14, 2020
hycdong
added a commit
to hycdong/rdsn
that referenced
this pull request
Jul 14, 2020
This was referenced Jul 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about sync bulk load info from remote storage while starting meta server.
_sync_bulk_load_storageto simplify code