Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

refactor: move nfs module from src/dist/nfs to src/nfs #538

Merged
merged 6 commits into from
Jul 9, 2020
Merged

refactor: move nfs module from src/dist/nfs to src/nfs #538

merged 6 commits into from
Jul 9, 2020

Conversation

levy5307
Copy link
Contributor

@levy5307 levy5307 commented Jul 8, 2020

Code refactor. Here is the future plan: #141

acelyc111
acelyc111 previously approved these changes Jul 9, 2020
View reviewed changes
@hycdong
Copy link
Contributor

hycdong commented Jul 9, 2020 •
edited
Loading

nfs_types.h and nfs_types.cpp are auto-generated by thrift compiler, you should also change its path in file compile_thrift.py, otherwise, we should move files manually when updating thrift structure.

@levy5307
Copy link
Contributor Author

levy5307 commented Jul 9, 2020

nfs_types.h and nfs_types.cpp are auto-generated by thrift compiler, you should also change its path in file compile_thrift.py, otherwise, we should move files manually when updating thrift structure.

I have changed it. Please have a look

@levy5307 levy5307 merged commit 1a5b8ed into XiaoMi:master Jul 9, 2020
@levy5307 levy5307 deleted the nfs branch July 9, 2020 13:55
@hycdong hycdong mentioned this pull request Aug 17, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hycdong hycdong hycdong approved these changes

@neverchanje neverchanje neverchanje approved these changes

@vagetablechicken vagetablechicken vagetablechicken left review comments

@acelyc111 acelyc111 acelyc111 left review comments

Assignees
No one assigned
Labels
2.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@levy5307 @hycdong @neverchanje @acelyc111 @vagetablechicken