This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
refactor: decouple sys_exit_type with dsn_runtime #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
changed the title
refactor: move sys_exit_type to a seperated file which are decoupled with dsn_runtime
refactor: move sys_exit_type to a seperated file which is decoupled with dsn_runtime
Jul 3, 2020
acelyc111
previously approved these changes
Jul 4, 2020
neverchanje
changed the title
refactor: move sys_exit_type to a seperated file which is decoupled with dsn_runtime
refactor: decouple sys_exit_type with dsn_runtime
Jul 4, 2020
DSN_API extern join_point<void, sys_exit_type> sys_exit; NORETURN DSN_API void dsn_exit(int code)
{
printf("dsn exit with code %d\n", code);
fflush(stdout);
::dsn::tools::sys_exit.execute(::dsn::SYS_EXIT_NORMAL);
_exit(code);
} You can move |
Done. |
neverchanje
approved these changes
Jul 4, 2020
hycdong
approved these changes
Jul 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some types which are defined in dsn_runtime being used in
global_config.h
, so this file is coupled with dsn_runtime. And nowsys_exit_type
is defined in this file. So if you want to usesys_exit_type
, you must coupled with dsn_runtime, which is not what we want. So in this pull request, I putsys_exit_type
to a seperated file.And remove the include of
global_config.h
ininclude/dsn/tool_api.h
, which is widely included in rdsn.