This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor(aio): simplify disk_engine interfaces #528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
disk_engine
was somehow designed as a middle layer between "file_io" API and "aio_provider" API.For example,
file::flush
forwards the call todisk_engine::flush
, then forwards toaio_provider::flush
.As a middle layer,
disk_engine
adds complexity of the code but doesn't bring abstraction aboveaio_provider
. So I plan to reduce the functionalities of this class. I may eventually remove this class.