This repository was archived by the owner on Jun 23, 2022. It is now read-only.
refactor: use DSN_REGISTER_COMPONENT_PROVIDER to register aio_provider #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 17, 2020 19:56
added 4 commits
June 18, 2020 15:08
added 4 commits
June 19, 2020 11:07
hycdong
approved these changes
Jun 19, 2020
vagetablechicken
approved these changes
Jun 22, 2020
acelyc111
approved these changes
Jun 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. In rdsn, if we want to register a component provider, we should add register_component_provider in providers.common.cpp, which is a file in dsn_runtime. So the module is coupled with dsn_runtime.
In this pull request, we implement DSN_REGISTER_COMPONENT_PROVIDER. If you want to register a component provider for your module, you can add a DSN_REGISTER_COMPONENT_PROVIDER in this module, and let this module decoupled from dsn_runtime.
2. use DSN_REGISTER_COMPONENT_PROVIDER to register aio_provider