This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(task): add an interface to query thread info #464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why copy a new service_engine and task_engine here? |
acelyc111
reviewed
May 19, 2020
License
neverchanje
reviewed
May 19, 2020
include/dsn/tool-api/threads_info.h
Outdated
Comment on lines
9
to
19
| namespace dsn { | ||
| namespace replication { | ||
|
|
||
| class thread_info | ||
| { | ||
| public: | ||
| static std::vector<task_worker *> &get_info(int code); | ||
| }; | ||
|
|
||
| } // namespace replication | ||
| } // namespace dsn |
There was a problem hiding this comment.
Suggested change
| namespace dsn { | |
| namespace replication { | |
| class thread_info | |
| { | |
| public: | |
| static std::vector<task_worker *> &get_info(int code); | |
| }; | |
| } // namespace replication | |
| } // namespace dsn | |
| namespace dsn { | |
| const std::vector<task_worker *> &get_task_code_threads_info(task_code code); | |
| } // namespace dsn |
There is nothing related to replication, so don't wrap the function in 'dsn::replication::' namespace.
Put this function to dsn/tool-api/task.h, since it's a utility of the task module.
neverchanje
changed the title
neverchanje
reviewed
May 19, 2020
include/dsn/tool-api/task.h
Outdated
Comment on lines
253
to
254
| // code is in dsn/dist/replication/replication.codes.h | ||
| static std::vector<task_worker *> &get_info(int code); |
There was a problem hiding this comment.
Suggested change
| // code is in dsn/dist/replication/replication.codes.h | |
| static std::vector<task_worker *> &get_info(int code); | |
| static const std::vector<task_worker *> &get_task_code_threads_info(task_code code); |
Don't make it static member in class task, put it in global space.
The task code is not always in dsn/dist/replication/replication.codes.h, remove the comment.
The returned value must be const.
neverchanje
reviewed
May 19, 2020
acelyc111
previously approved these changes
May 21, 2020
Smityz
force-pushed
the
hotspot_thread_formal
branch
from
50d81c9 to
8ef1d0c
Compare
neverchanje
reviewed
May 21, 2020
include/dsn/tool-api/task.h
Outdated
| @@ -614,6 +614,8 @@ class aio_task : public task | |||
| }; | |||
| typedef dsn::ref_ptr<aio_task> aio_task_ptr; | |||
|
|
|||
| const std::vector<task_worker *> &get_task_code_threads_info(threadpool_code code); | |||
There was a problem hiding this comment.
get_threadpool_threads_info
neverchanje
approved these changes
May 21, 2020
acelyc111
approved these changes
May 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an interface to query thread info