This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(bulk-load): group bulk load request in replica group #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
May 14, 2020
| for (const auto &kv : _primary_states.group_bulk_load_pending_replies) { | ||
| kv.second->cancel(true); | ||
| } | ||
| _primary_states.group_bulk_load_pending_replies.clear(); |
There was a problem hiding this comment.
Does it mean we will resend group_bulk_load_request to sendaries? How does secondary replica deal with duplicate bulk load request?
There was a problem hiding this comment.
- meta -> primary: send bulk _load_request
- primary -> secondary: send group_bulk_load_request (request 1)
- secondary -> primary : report bulk load state
- primary -> meta: report group bulk load states
- if bulk load not finished, meta send bulk_load_request again
- primary -> secondary: send group_bulk_load_request (request 2)
Primary will not resend group_bulk_load_request, request 1 and request 2 are different.
When primary tries to send request 2, primary will check if there are request 1 pending firstly, if there are pending request 1, primary will cancel tasks and send request 2.
Meta server will not send bulk_load_request too soon, the interval is longer than 5 seconds (will be shown in further pull request), it is safe to cancel the long-time, pending request.
acelyc111
previously approved these changes
May 14, 2020
levy5307
reviewed
May 15, 2020
neverchanje
reviewed
May 15, 2020
acelyc111
approved these changes
May 15, 2020
neverchanje
approved these changes
May 15, 2020
hycdong
added a commit
to hycdong/rdsn
that referenced
this pull request
May 20, 2020
This was referenced May 28, 2020
This was referenced Jun 15, 2020
Merged
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is about primary broadcast group_bulk_load_request to secondaries.
on_bulk_loadfeat(bulk-load): meta server send bulk load request #457)broadcast_group_bulk_load)on_group_bulk_loadwhen receive group_bulk_load_requeston_group_bulk_load_replywhen receive group_bulk_load_response, part-implemented in this prWhole bulk load process document can be found in official website: bulk_load_design