Skip to content
This repository has been archived by the owner on Jun 23, 2022. It is now read-only.

feat(bulk-load): add meta_bulk_load_service and some structures #445

Merged
merged 19 commits into from
Apr 30, 2020

Conversation

hycdong
Copy link
Contributor

@hycdong hycdong commented Apr 23, 2020

This pull request includes:

  • Structure definition:
    • is_bulk_loading flag for app_info
    • bulk load related structure on zk: app_bulk_load_info and partition_bulk_load_info
    • bulk load related structure on remote file provider: bulk_load_info and bulk_load_metadata
  • Init and start bulk load service while starting meta service, create bulk_load dir on zk
  • Add other basic varieties, structures and function deceleration.

@@ -151,6 +153,13 @@ class backup_restore_constant
static const std::string SKIP_BAD_PARTITION;
};

class bulk_load_constant
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can change the type of bulk_load_constant from class to struct, because the member variables are all public.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used class here is just like replica_envs class, I would like to organize const varieties who used in a same function in a namespace.

acelyc111
acelyc111 previously approved these changes Apr 27, 2020
@neverchanje neverchanje merged commit b9e2bbe into XiaoMi:master Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants