This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
build(deps): use cmake ExternalProject to manage dependencies #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
approved these changes
Jul 28, 2020
acelyc111
approved these changes
Jul 28, 2020
hycdong
added
the
area/installation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to manage dependencies using
thirdparty/download-thirdparty.shandthirdparty/build-thirdparty.sh. They need heavy human script work to add a dep.CMake ExternalProject is currently the rule of thumb approach to dependency management in C++. Another approach like Bazel and Meson require much effort to refactor our building process, so they are not in our options.
conan, vcpkg are good tools, but their aims are to manage binary of the dependencies. The binaries are limited to the platform they're built. So they have no advantages compared to CMake in terms of managing the building process of 3rdparties.
Apart from refactoring with CMake ExternalProject, I also include boost libraries (system/filesystem/regex) as a dep. I use boost -1.69 (which is not the latest but I think is more stable). So we never have to build with
anymore.
Testing:
This PR is tested on: