This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
utility: table_printer
support output in json mode.
#223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
qinzuoyan
reviewed
Feb 26, 2019
@@ -738,7 +742,7 @@ dsn::error_code replication_ddl_client::cluster_info(const std::string &file_nam | |||
for (int i = 0; i < resp.keys.size(); i++) { | |||
tp.add_row_name_and_data(resp.keys[i], resp.values[i]); | |||
} | |||
tp.output(out, ": "); | |||
tp.output(out); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里原始是冒号分隔,现在变成了空格分隔?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
现在这种单列数据的都固定使用:
, 多列的使用空格
, 不可配置,实际上也不需配置
neverchanje
reviewed
Feb 26, 2019
fiexd |
qinzuoyan
reviewed
Feb 26, 2019
neverchanje
previously approved these changes
Feb 27, 2019
neverchanje
approved these changes
Mar 4, 2019
qinzuoyan
approved these changes
Mar 4, 2019
24 tasks
neverchanje
pushed a commit
that referenced
this pull request
Jun 14, 2019
19 tasks
neverchanje
pushed a commit
that referenced
this pull request
Jun 21, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.