This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
split: add app_partition_split request and unit test #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # include/dsn/dist/replication/replica_test_utils.h # src/dist/replication/lib/replica.h # src/dist/replication/meta_server/meta_state_service_utils.cpp # src/dist/replication/meta_server/meta_state_service_utils_impl.h # src/dist/replication/meta_server/split/meta_split_service.cpp # src/dist/replication/test/meta_test/unit_test/meta_state_service_utils_test.cpp
# Conflicts: # include/dsn/dist/replication/replication.types.h # include/dsn/dist/replication/replication_types.h # src/dist/replication/lib/replica.h # src/dist/replication/replication.thrift
# Conflicts: # include/dsn/dist/replication/replication.types.h # include/dsn/dist/replication/replication_types.h # src/dist/replication/lib/replica.h # src/dist/replication/replication.thrift
# Conflicts: # include/dsn/cpp/pipeline.h # include/dsn/dist/replication/replication.codes.h # include/dsn/dist/replication/replication_types.h # src/dist/replication/client_lib/replication_types.cpp # src/dist/replication/lib/replica.h # src/dist/replication/lib/replica_stub.cpp # src/dist/replication/meta_server/meta_state_service_utils.cpp # src/dist/replication/meta_server/meta_state_service_utils_impl.h # src/dist/replication/test/meta_test/unit_test/meta_state_service_utils_test.cpp
# Conflicts: # include/dsn/cpp/pipeline.h # include/dsn/dist/replication/replication.codes.h # include/dsn/dist/replication/replication_types.h # src/dist/replication/client_lib/replication_types.cpp # src/dist/replication/lib/replica.h # src/dist/replication/lib/replica_stub.cpp # src/dist/replication/meta_server/meta_state_service_utils.cpp # src/dist/replication/meta_server/meta_state_service_utils_impl.h # src/dist/replication/test/meta_test/unit_test/meta_state_service_utils_test.cpp
neverchanje
reviewed
Jun 21, 2018
| @@ -3,84 +3,89 @@ | |||
| #include <dsn/service_api_cpp.h> | |||
| #include <dsn/cpp/serialization.h> | |||
|
|
|||
| namespace dsn { | |||
neverchanje
reviewed
Jun 21, 2018
| } | ||
|
|
||
| meta_split_service::meta_split_service(meta_service* meta_srv){ | ||
| this->_meta_svc = meta_srv; |
neverchanje
reviewed
Jun 21, 2018
| copy.partition_count *= 2; | ||
| blob value = dsn::json::json_forwarder<app_info>::encode(copy); | ||
|
|
||
| _meta_svc->get_remote_storage()->set_data( |
There was a problem hiding this comment.
用 meta storage， 不要用 remote storage
There was a problem hiding this comment.
重试的时候优先级会变高，task_code会变成LPC_META_STATE_HIGH，这次功能开发先这样写，我会把它记作TODO，之后重构的时候再改
There was a problem hiding this comment.
所有写 zk 的优先级都应该是 high, 不需要在重试的时候改
|
include/dsn/cpp/serialization_helper/dsn.layer2_types.h |
neverchanje
reviewed
Jun 22, 2018
| } else if (ec == ERR_TIMEOUT) { | ||
| dwarn_f("remote storage is not available now, please try it later"); | ||
| tasking::enqueue(LPC_META_STATE_HIGH, | ||
| nullptr, |
There was a problem hiding this comment.
remote storage 是用来省代码来让逻辑更清晰的. 你这里的 tracker 就是传 null, 是不安全的.
remote storage 帮你省掉 timeout 重试, error abort 的代码, 你应该去尝试使用一下.
neverchanje
reviewed
Jun 22, 2018
| std::move(app), | ||
| std::move(rpc)), | ||
| 0, | ||
| std::chrono::seconds(1)); |
There was a problem hiding this comment.
推荐使用 1_s = std::chrono::seconds(1)), see https://github.com/XiaoMi/rdsn/blob/master/include/dsn/utility/chrono_literals.h
比如 tasking::enqueue(..., 1_s);
|
刚刚交了一个新的commit，把code format都加上了 @neverchanje |
|
哪个提交? 现在 diff 还是没 format |
|
commit 8a62162 |
neverchanje
added
type/enhancement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app_partition_split is the request which client send to meta server, meta server will validate request and change partition count on remote storage.
refer to #69