This repository has been archived by the owner on Jul 12, 2023. It is now read-only.
Fix NotifyOnFlushCompleted() for atomic flush (#8585) #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
PR facebook/rocksdb#5908 added
flush_jobs_info_
toFlushJob
to make sureOnFlushCompleted()
is called after committing flush results toMANIFEST. However,
flush_jobs_info_
is not updated in atomicflush, causing
NotifyOnFlushCompleted()
to skipOnFlushCompleted()
.This PR fixes this, in a similar way to facebook/rocksdb#5908 that handles regular flush.
Pull Request resolved: facebook/rocksdb#8585
Test Plan: make check
Reviewed By: jay-zhuang
Differential Revision: D29913720
Pulled By: riversand963
fbshipit-source-id: 4ff023c98372fa2c93188d4a5c8a4e9ffa0f4dda