Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
const_in_array_repeat_expressions
have been removed due to ambiguous drop order of?Sised
objects and other whatever reasons link.And workaround is to make a constant for the value:
And below the using 0 as
*const ()
is probably safe, but better to use ptr::null() and clippy also has style lint for this situation zero_ptrValue of NULL is guaranteed by the standard to be 0. In practice, this particular feature was used in the first PDP machines, if I am not mistaken. if (ptr) and if (ptr == 0) and if (ptr == NULL) are always and everywhere equivalent https://twitter.com/typesanitizer/status/1333171905872891904
p.s.: I'm good at bad names :x