Added support for fastlane auth cookies #265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tahirmt
reviewed
Jan 10, 2023
|
|
||
| func load(in storage: HTTPCookieStorage?) { | ||
| do { | ||
| guard let storage, var sessionVar = Current.shell.env(fastlaneSession) else { return } |
There was a problem hiding this comment.
I think it's also valuable to automatically load the cookie if it is present in the filesystem. fastlane stores it in the file ~/.fastlane/spaceship/email@domain.com/cookie.
tahirmt
reviewed
Jan 10, 2023
| import Foundation | ||
| import Yams | ||
|
|
||
| struct FastlaneCookieLoader { |
There was a problem hiding this comment.
Do you mind adding some tests for this?
|
This will close #248 |
|
Also possible duplicate of #257 |
|
@omarzl can you close this PR if it isn't needed? |
|
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #141
Inspired by this fork commit: tahirmt@2da7761
fastlane spaceauth generates a YML session string so we can parse it directly and inject those cookies into the session's cookies storage.
I kept the
FASTLANE_SESSIONenv var name to have direct support with fastlane.Steps
You will now be able to download Xcode in CI environments by first running locally:
And then in your CI scripts you can export the variable and run
xcodes, it won't prompt for username/password/2fa:References:
https://github.com/fastlane/fastlane/blob/master/spaceship/lib/spaceship/client.rb#L280
https://github.com/sparklemotion/http-cookie/blob/master/lib/http/cookie_jar/yaml_saver.rb#L19