Add experimental unxip flag #187
Conversation
Source: https://github.com/saagarjha/unxip This mirrors this change in Xcodes.app: XcodesOrg/XcodesApp#179 In my tests (M1 Max, 64GB RAM), unxipping is 3x faster than `/usr/bin/xip`.
|
Based on my layman's understanding of the LGPL license, I believe this usage complies with its requirements that any modifications to the source file be made available under the same license, but I am not a lawyer. |
| @@ -90,6 +90,34 @@ | |||
| ReferencedContainer = "container:"> | |||
| </BuildableReference> | |||
| </BuildActionEntry> | |||
| <BuildActionEntry | |||
There was a problem hiding this comment.
Xcode added this automatically
I removed this by mistake.
There was a problem hiding this comment.
Super appreciative @jpsim!
Just some picky log additions to help indicate which side of the unxip world they are in!
Thanks again!
| Current.logging.log(InstallationStep.unarchiving.description) | ||
|
|
||
| if experimentalUnxip, #available(macOS 11, *) { | ||
| return Promise { seal in |
There was a problem hiding this comment.
#picky
Can we add another log statement here indicating they're in experiment mode. something like
Current.logging.log("Using experimental unxip! If any issues, remove flag and try again")
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
And similar to inside experiment - can we indicate to try the experiment
Current.logging.log("Using regular unxip - try passing in --expermiental-unxip to try a faster unxip process.")
Co-authored-by: Matt Kiazyk <mattkiazyk@gmail.com>
|
By the way, CI never ran on this PR because this repo has CI configured to require maintainer approval for PRs from first-time contributors. |
|
yeah.. pretty sure it's broken at the moment, so I just merged it in |
This mirrors this change in Xcodes.app: XcodesOrg/XcodesApp#179
In my tests (M1 Max, 64GB RAM), unxipping is 3x faster than
/usr/bin/xip. I measured unxipping Xcode 13.3 beta 3 twice with the flag on (~100s) and off (~300s).To use this, you need to be running macOS 11 or later, and pass the
--experimental-unxipflag to anxcodes installcommand.E.g.