Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#322] Bug: Browser is not started for @After method if it's declared in different class than the test itself #325

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

oomelianchuk
Copy link
Contributor

No description provided.

@oomelianchuk oomelianchuk self-assigned this Dec 13, 2024
@oomelianchuk oomelianchuk changed the title Bug: Browser is not started for @After method if it's declared in different class than the test itself [#322] Bug: Browser is not started for @After method if it's declared in different class than the test itself Dec 13, 2024
private static final String SYSTEM_PROPERTY_BROWSERDEFINITION = "browserdefinition";

public BrowserData(Class<?> testClass)
{
this();
this.testClass = testClass;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.testClass = testClass; is also part of initClassAnnotationsFor(Class<?> testClass) in the next line.
Please remove one of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Browser is not started for @After method if it's declared in different class than the test itself
2 participants