Added NeoWaitTime #296
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| package com.xceptance.neodymium.util; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import com.codeborne.selenide.Selenide; | ||
|
|
||
| public class NeoWaitTime | ||
| { | ||
|
There was a problem hiding this comment. The simple |
||
| private final int standardWait, shortWait, doubleWait, longWait; | ||
|
|
||
| private final Map<String, String> customWaitTimeMap; | ||
|
|
||
| private static NeoWaitTime INSTANCE; | ||
|
|
||
| private NeoWaitTime() { | ||
| this.standardWait = Neodymium.configuration().getStandardWaitTime(); | ||
| this.shortWait = Neodymium.configuration().getShortWaitTime(); | ||
| this.doubleWait = Neodymium.configuration().getDoubleWaitTime(); | ||
| this.longWait = Neodymium.configuration().getLongWaitTime(); | ||
| this.customWaitTimeMap = PropertiesUtil.getPropertiesMapForCustomIdentifier("neodymium.waitTime.custom"); | ||
| } | ||
|
|
||
| public static void waitStandardWaitTime() | ||
| { | ||
| if (INSTANCE == null) | ||
| { | ||
| INSTANCE = new NeoWaitTime(); | ||
| } | ||
| Selenide.sleep(INSTANCE.standardWait); | ||
| } | ||
|
|
||
| public static void waitShortWaitTime() | ||
| { | ||
| if (INSTANCE == null) | ||
| { | ||
| INSTANCE = new NeoWaitTime(); | ||
| } | ||
| Selenide.sleep(INSTANCE.shortWait); | ||
| } | ||
|
|
||
| public static void waitDoubleWaitTime() | ||
| { | ||
| if (INSTANCE == null) | ||
| { | ||
| INSTANCE = new NeoWaitTime(); | ||
| } | ||
| Selenide.sleep(INSTANCE.doubleWait); | ||
| } | ||
|
|
||
| public static void waitLongWaitTime() | ||
| { | ||
| if (INSTANCE == null) | ||
| { | ||
| INSTANCE = new NeoWaitTime(); | ||
| } | ||
| Selenide.sleep(INSTANCE.longWait); | ||
| } | ||
|
|
||
| public static void waitCustomWaitTime(String key) | ||
| { | ||
| if (INSTANCE == null) | ||
| { | ||
| INSTANCE = new NeoWaitTime(); | ||
| } | ||
| Selenide.sleep(Integer.valueOf(INSTANCE.customWaitTimeMap.get(key))); | ||
|
There was a problem hiding this comment. We should add a proper handling if the key given is not present and produce a proper error message, otherwise a not very communicative NullPointerException will be thrown |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some reconsideration on how to make this functionality as easy to access as possible (and easy to find without reading the whole documentation), Let's change the approach a bit:
waitStandardWaitTime()) directly to the Neodymium Class so that a user can callNeodymium.waitStandardWaitTime()I'll update the ticket for clarification as well.