Dependency update snakeyaml #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oomelianchuk
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
The changes seem good to me. The Jenkins run for this branch was also successful. Thanks @RobertAvemarg for the great work!
occupant23
suggested changes
Dec 13, 2022
| $("#search-container .search-field").val("searchphrase").submit(); | ||
| openPostersStartPage(); | ||
| $("#header-search-trigger").click(); | ||
| $("#searchForm input").val("bear").submit(); |
There was a problem hiding this comment.
Use 'mozzarella' as search term and perform similar like in the old example.
(Use ^ and $ in the regex)
| $("#search-container .search-field").val("searchphrase").submit(); | ||
| openPostersStartPage(); | ||
| $("#header-search-trigger").click(); | ||
| $("#searchForm input").val("bear").submit(); |
There was a problem hiding this comment.
Use 'mozzarella' as search term and perform similar like in the old example.
|
@RobertAvemarg I found some small things please adjust. |
occupant23
approved these changes
Dec 13, 2022
|
@oomelianchuk Please perform the merge and release it together with @RobertAvemarg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated snakeyaml dependency and we changed the website from xceptance to posters.xceptance.io and adjusted the slider value in SelenideAddonsTest to make the tests pass again