Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get remote webdriver #115 issue #116

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Add get remote webdriver #115 issue #116

merged 2 commits into from
Mar 31, 2020

Conversation

oomelianchuk
Copy link
Contributor

No description provided.

@oomelianchuk oomelianchuk requested a review from occupant23 March 31, 2020 08:48
@occupant23 occupant23 self-assigned this Mar 31, 2020
@oomelianchuk oomelianchuk changed the base branch from master to develop March 31, 2020 08:53
occupant23
occupant23 suggested changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@occupant23 occupant23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change like proposed

src/main/java/com/xceptance/neodymium/util/Neodymium.java Outdated
@@ -132,6 +134,12 @@ public static WebDriver getDriver()
return getContext().driver;
}

public static RemoteWebDriver getRemoteWebDriver()
{
EventFiringWebDriver eventFiringWebDriver = (EventFiringWebDriver) getDriver();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create a own public method getEventFiringWebDriver and use it here

@oomelianchuk oomelianchuk requested a review from occupant23 March 31, 2020 09:37
occupant23
occupant23 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@occupant23 occupant23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine

@occupant23 occupant23 merged commit 185efbd into develop Mar 31, 2020
@occupant23 occupant23 deleted the add-get-remote-webdriver-#115-issue branch April 3, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@occupant23 occupant23 occupant23 approved these changes

Assignees

@occupant23 occupant23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oomelianchuk @occupant23