Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement a clean up without parameters #78

Closed
ckeiner opened this issue Apr 3, 2019 · 2 comments
Closed

Implement a clean up without parameters #78

ckeiner opened this issue Apr 3, 2019 · 2 comments
Assignees
@occupant23 @ckeiner
Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there feature Low Priority
Milestone
v3.2.x

Comments

@ckeiner
Copy link

ckeiner commented Apr 3, 2019

I want to be able to close the browser during a test case. This seems possible for Cucumber, where the teardown-method is used to clean up after a scenario was run, thus also expecting a Scenario as argument. Yet, I'd like to use such a clean up without using Cucumber. Therefore is it possible you could implement such a teardown-method without parameters?
@occupant23 occupant23 self-assigned this Apr 17, 2019
@occupant23 occupant23 added this to the v3.2.x milestone Apr 17, 2019
@occupant23
Copy link
Contributor

Implemented as WebDriverUtils.tearDown(boolean isFailed) in order to make use of Neodymium's keepBrowserOpenOnFailure feature.

occupant23 pushed a commit that referenced this issue Apr 17, 2019
#78: webdriver tear down without the Scenario as a parameter
7f6f816
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Apr 17, 2019
@occupant23
Copy link
Contributor

@ckeiner: Ready to test

@ckeiner ckeiner added the codeDone The issue is rechecked for development branch label Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@occupant23 occupant23

@ckeiner ckeiner

Labels
codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there feature Low Priority
Projects
None yet
Milestone
v3.2.x
Development

No branches or pull requests
2 participants
@occupant23 @ckeiner