Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-neodymium does not override neodymium.properties #74

Closed
rkl-xc opened this issue Feb 13, 2019 · 3 comments
Closed

dev-neodymium does not override neodymium.properties #74

rkl-xc opened this issue Feb 13, 2019 · 3 comments
Assignees
@occupant23
Labels
bug codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there High Priority
Milestone
v3.1.0

Comments

@rkl-xc
Copy link
Contributor

rkl-xc commented Feb 13, 2019

Once I had to set the neodymium.webDriver.chrome.pathToDriverServer (and firefox) at neodymium.properties I expect them to be overridden with the same settings at dev-neodymium.properties in place. But running this the setting from neodymium.properties has been used. I worked around by passing these parameters through the command line switches using -Dneodymium.webDriver.chrome.pathToDriverServer=
@occupant23 occupant23 self-assigned this Feb 15, 2019
@occupant23 occupant23 added this to the v3.1.0 milestone Feb 15, 2019
occupant23 pushed a commit that referenced this issue Feb 18, 2019
#74: fixed an issue with neodymium dev configuration (false order in …
554cc82 
…override queue)
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Feb 18, 2019
@occupant23
Copy link
Contributor

fixed the bug, ready for test

@jowerner
Copy link

The test case (setup) might not work as intended. Two issues here:

  • The test case setup creates a file such as "./config/dev-neodymium1145134166378993830" which I believe will never be read. Did you want to create "./config/dev-neodymium.properties" instead?
  • The other file "./config/temp-neodymium.properties" will be read, but this file does not really overwrite a setting with a different value so the test case does not prove anything.

@jowerner jowerner removed the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Feb 20, 2019
@occupant23 occupant23 added the codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there label Feb 20, 2019
@occupant23
Copy link
Contributor

rethought tests and fixed the issue

occupant23 pushed a commit that referenced this issue Feb 20, 2019
#74: reworked test setup
6efe38a
@jowerner jowerner added the codeDone The issue is rechecked for development branch label Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@occupant23 occupant23

Labels
bug codeDone The issue is rechecked for development branch codeReadyForRecheck The issue is fixed/implemented AND merged into development, but needs to be rechecked there High Priority
Projects
None yet
Milestone
v3.1.0
Development

No branches or pull requests
3 participants
@jowerner @occupant23 @rkl-xc